Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P plugin-audio-subsonic
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Warwick Harris
  • plugin-audio-subsonic
  • Merge requests
  • !18

Path support and security improvements

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Warwick Harris requested to merge feature/path-support_and_pw-improvements into master Nov 25, 2017
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: ghost

  1. Fixes a security issue where the password is sent as plaintext in the URL query parameters when methods from libsonic_extas are used. Also adds Subsonic hex encoding when using legacy auth.

  2. Adds support for URL paths like https://hostname.com/subsonic as requested in #17 (closed) and also encountered in some of the reports in #14 (closed) and #5 (closed)

  3. Fixes an error when the password only contains digits, which simpleplugin converts to a Long, which later fails when libsonic tries to salt the password expecting a string.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/path-support_and_pw-improvements